avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Baldassari" <jbaldass...@gmail.com>
Subject Re: Review Request: Patch for AVRO-539 (asynchronous RPCs)
Date Mon, 06 Jun 2011 02:28:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/834/
-----------------------------------------------------------

(Updated 2011-06-06 02:28:52.551649)


Review request for Avro.


Changes
-------

Updated with version 2 of the patch.


Summary
-------

See https://issues.apache.org/jira/browse/AVRO-539


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/avro/trunk/lang/java/compiler/src/main/java/org/apache/avro/compiler/specific/ProtocolTask.java
1130417 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/compiler/src/main/java/org/apache/avro/compiler/specific/SchemaTask.java
1130417 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/compiler/src/main/java/org/apache/avro/compiler/specific/SpecificCompiler.java
1130417 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/compiler/src/main/velocity/org/apache/avro/compiler/specific/templates/java/classic/protocol-client.vm
PRE-CREATION 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/ipc/pom.xml 1130417 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/ipc/src/main/java/org/apache/avro/ipc/CallFuture.java
PRE-CREATION 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/ipc/src/main/java/org/apache/avro/ipc/Callback.java
PRE-CREATION 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/ipc/src/main/java/org/apache/avro/ipc/NettyServer.java
1130417 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/ipc/src/main/java/org/apache/avro/ipc/NettyTransceiver.java
1130417 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/ipc/src/main/java/org/apache/avro/ipc/Requestor.java
1132512 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/ipc/src/main/java/org/apache/avro/ipc/Responder.java
1130417 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/ipc/src/main/java/org/apache/avro/ipc/Transceiver.java
1130417 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/ipc/src/main/java/org/apache/avro/ipc/TransceiverCallback.java
PRE-CREATION 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/ipc/src/main/java/org/apache/avro/ipc/generic/GenericRequestor.java
1132512 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/ipc/src/main/java/org/apache/avro/ipc/specific/SpecificRequestor.java
1132512 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/ipc/src/main/java/org/apache/avro/ipc/specific/SpecificResponder.java
1130417 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/ipc/src/test/java/org/apache/avro/TestProtocolGeneric.java
1132512 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/ipc/src/test/java/org/apache/avro/TestProtocolNetty.java
PRE-CREATION 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/ipc/src/test/java/org/apache/avro/TestProtocolSpecific.java
1130417 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/ipc/src/test/java/org/apache/avro/compiler/specific/TestSpecificCompiler.java
1130417 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/ipc/src/test/java/org/apache/avro/ipc/TestNettyServerWithCallbacks.java
PRE-CREATION 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/maven-plugin/src/main/java/org/apache/avro/mojo/AbstractAvroMojo.java
1130417 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/maven-plugin/src/main/java/org/apache/avro/mojo/IDLProtocolMojo.java
1130417 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/maven-plugin/src/main/java/org/apache/avro/mojo/ProtocolMojo.java
1130417 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/maven-plugin/src/main/java/org/apache/avro/mojo/SchemaMojo.java
1130417 
  http://svn.apache.org/repos/asf/avro/trunk/lang/java/tools/src/main/java/org/apache/avro/tool/SpecificCompilerTool.java
1130417 

Diff: https://reviews.apache.org/r/834/diff


Testing
-------

All existing unit tests pass.  Wrote new unit tests for the new async functionality.


Thanks,

James


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message