Return-Path: X-Original-To: apmail-avro-dev-archive@www.apache.org Delivered-To: apmail-avro-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BFE665E36 for ; Thu, 12 May 2011 14:42:30 +0000 (UTC) Received: (qmail 17254 invoked by uid 500); 12 May 2011 14:42:30 -0000 Delivered-To: apmail-avro-dev-archive@avro.apache.org Received: (qmail 17203 invoked by uid 500); 12 May 2011 14:42:30 -0000 Mailing-List: contact dev-help@avro.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@avro.apache.org Delivered-To: mailing list dev@avro.apache.org Received: (qmail 17195 invoked by uid 99); 12 May 2011 14:42:30 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 May 2011 14:42:30 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 May 2011 14:42:26 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 5383487E38 for ; Thu, 12 May 2011 14:41:47 +0000 (UTC) Date: Thu, 12 May 2011 14:41:47 +0000 (UTC) From: "Douglas Creager (JIRA)" To: dev@avro.apache.org Message-ID: <1335135936.6847.1305211307338.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1932827506.6818.1305210227710.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (AVRO-819) C library not propagating error codes when reading files MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AVRO-819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Douglas Creager updated AVRO-819: --------------------------------- Attachment: 0001-AVRO-819.-Propagate-errors-correctly-in-C-library.patch Here's a fix, along with a test case. Just needed to update a couple of the "check" macros in avro_private.h to return error rvals. > C library not propagating error codes when reading files > -------------------------------------------------------- > > Key: AVRO-819 > URL: https://issues.apache.org/jira/browse/AVRO-819 > Project: Avro > Issue Type: Bug > Components: c > Affects Versions: 1.5.1 > Reporter: Douglas Creager > Assignee: Douglas Creager > Attachments: 0001-AVRO-819.-Propagate-errors-correctly-in-C-library.patch > > > The C library's data file reader isn't propagating error codes correctly, which causes avro_file_reader_read to not correctly detect EOF. Instead, it will return as if it's reading the final block of the file twice, though it's not filling in the datum parameter for the second pass through the block. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira