avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Scott Carey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-827) Use portable shell syntax for build.sh
Date Thu, 26 May 2011 16:23:48 GMT

    [ https://issues.apache.org/jira/browse/AVRO-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039760#comment-13039760
] 

Scott Carey commented on AVRO-827:
----------------------------------

Another issue is the use of a lot of subshells and the fail on error 'set -e' parameter. 
Different shells and different versions of bash do different things with these in combination.

In bash 3.x (on my Mac) this makes '-e' useless.  The C build can fail, and the script will
continue despite 'set -e'.  Later versions of bash will bubble subshell failures up.  If that
isn't portable amongst bash versions, it is probably not portable across other shell interpreters
either.

None of the above is relevant to this patch though, declaring a function in a more portable
way is fine by me.

> Use portable shell syntax for build.sh
> --------------------------------------
>
>                 Key: AVRO-827
>                 URL: https://issues.apache.org/jira/browse/AVRO-827
>             Project: Avro
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 1.6.0
>         Environment: Operating systems with a POSIX compliant {{/bin/sh}}.
>            Reporter: Joseph Koshy
>              Labels: bash, build, posix, sh
>         Attachments: build.sh.txt
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> Avro's {{build.sh}} script cannot be executed by a POSIX compatible {{sh}}.
> {quote}
> % /bin/sh build.sh
> build.sh: 24: function: not found
> {quote}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message