avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] Updated: (AVRO-761) Requestor sends protocol text on each handshake under certain circumstances
Date Mon, 07 Mar 2011 21:14:59 GMT

     [ https://issues.apache.org/jira/browse/AVRO-761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Doug Cutting updated AVRO-761:
------------------------------

    Attachment: AVRO-761.patch

Here's a patch that includes tests.

RPCContext is altered to expose the entire handshake to plugins, not just the handshake metadata
as before.  TestProtocolSpecific is altered to check that a given client protocol is only
transmitted once, and its TestProtocolHttp is altered to make a second request over a different
protocol to trigger the bug.  Without the changes to Requestor setting sendLocalText=false
TestProtocolHttp now fails, with these changes is passes. 

> Requestor sends protocol text on each handshake under certain circumstances
> ---------------------------------------------------------------------------
>
>                 Key: AVRO-761
>                 URL: https://issues.apache.org/jira/browse/AVRO-761
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.4.1
>            Reporter: Richard Ahrens
>             Fix For: 1.5.1
>
>         Attachments: AVRO-761.patch, Requestor.java.patch
>
>
> When using a stateless transport such as HTTP and different protocol versions on client
and server, Requestor will send the local protocol text on each request once a handshake match
is established.  For large protocols, this slows things down considerably.  The attached patch
resolves the issue by resetting the sendLocalText field after a successful handshake.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message