avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thiruvalluvan M. G. (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AVRO-533) .NET implementation of Avro
Date Sun, 20 Mar 2011 14:42:30 GMT

    [ https://issues.apache.org/jira/browse/AVRO-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008905#comment-13008905

Thiruvalluvan M. G. commented on AVRO-533:

Thanks a lot Dona for taking this up.

I didn't do a proper review of the design or implementation. But I did build and had a cursory
look. Here are my observations:
   - I could cleanly compile on my Windows XP with Visual Studio Express 2010.
   - Two unit tests failed. (TestResolutionMismatch_simple of GenericTests and SpecificTests).
They failed because lines 123 to 126 in GenericReader.cs were commented out. Uncommenting
that fixes the problem.
   - The test for codegen has its assertions commented out. Uncommenting it still succeeds,
I'm not sure why they are commented. But still, I get an impression that the tests there is
inadequate. It merely tests that compilation of the generated code goes through. It doesn't
seem to test the contents of generated code.
   - Perhaps I'm missing something completely. To me, SpecificTests seems to test Generic
rather than Specific. What am I missing?
   - Protocol compiler is in place. But there is no server or client implementation. This
is fine, but I just wanted to check if my understanding is correct.

> .NET implementation of Avro
> ---------------------------
>                 Key: AVRO-533
>                 URL: https://issues.apache.org/jira/browse/AVRO-533
>             Project: Avro
>          Issue Type: New Feature
>    Affects Versions: 1.4.0
>            Reporter: Jeff Hammerbacher
>            Assignee: Thiruvalluvan M. G.
>         Attachments: AVRO-533.patch, AVRO-533.patch, AVRO-533.zip, csharp.zip, csharp_2nd_patch.zip,
dotnet.patch, failure.txt

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message