avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Scott Carey (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AVRO-726) Make GenericDatumReader/GenericDatumWriter data member protected so that it can be used by the derived classes
Date Thu, 17 Feb 2011 21:27:12 GMT

    [ https://issues.apache.org/jira/browse/AVRO-726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996090#comment-12996090
] 

Scott Carey commented on AVRO-726:
----------------------------------

Yes, I'll look at getting just the basics: set those to protected, done for 1.5.0.  I can't
guarantee it but it is the first thing I'll look at after the API changing blockers.

As for the patch, even if it only applies against 1.4.1, as long as it is posted here and
has the granted Apache license we can review and start talking about incorporating it or using
it as a base to build similar features that solve your use cases.  You might want to start
a new JIRA for that, and we'll leave this one for making the members protected only.

> Make GenericDatumReader/GenericDatumWriter data member protected so that it can be used
by the derived classes
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: AVRO-726
>                 URL: https://issues.apache.org/jira/browse/AVRO-726
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>    Affects Versions: 1.5.0
>            Reporter: Xiaolu Ye
>             Fix For: 1.5.0
>
>
> Currently, GenericDatumReader/GenericDatumWriter data members are private. Is it possible
to make them protected so that we could extend those classes and create our own special DatumReader/Writer?
The reason we want to do that is because we've created our own base SpecificRecordEx that
implements SpecificRecord and added put/get for primitive types. We now want to extend the
GenericDatumReader/GenericDatumWriter to use those primitive put/get functions to reduce box/unbox
for better performance. 
> Thanks,
> Xiaolu

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message