avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaolu Ye (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AVRO-726) Make GenericDatumReader/GenericDatumWriter data member protected so that it can be used by the derived classes
Date Fri, 18 Feb 2011 20:46:38 GMT

    [ https://issues.apache.org/jira/browse/AVRO-726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996589#comment-12996589
] 

Xiaolu Ye commented on AVRO-726:
--------------------------------

Hi Scott,

I've created jira AVRO-777 for the enhancement. Just want to mention that in addition to change
the data member to protected, could you also look at whether some of the member functions
could be made protected like npe() in GenericDatumWriter? I needed to use npe in my derived
class and had to change GenericDatumWriter in my local copy.

Thanks,

Xiaolu

> Make GenericDatumReader/GenericDatumWriter data member protected so that it can be used
by the derived classes
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: AVRO-726
>                 URL: https://issues.apache.org/jira/browse/AVRO-726
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>    Affects Versions: 1.5.0
>            Reporter: Xiaolu Ye
>             Fix For: 1.5.0
>
>
> Currently, GenericDatumReader/GenericDatumWriter data members are private. Is it possible
to make them protected so that we could extend those classes and create our own special DatumReader/Writer?
The reason we want to do that is because we've created our own base SpecificRecordEx that
implements SpecificRecord and added put/get for primitive types. We now want to extend the
GenericDatumReader/GenericDatumWriter to use those primitive put/get functions to reduce box/unbox
for better performance. 
> Thanks,
> Xiaolu

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message