avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip Zeyliger (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AVRO-723) Incorrect handling of Undeclared Errors in IPC calls to SpecificResponder
Date Sun, 02 Jan 2011 17:52:46 GMT

    [ https://issues.apache.org/jira/browse/AVRO-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976549#action_12976549
] 

Philip Zeyliger commented on AVRO-723:
--------------------------------------

Hi Stephen,

I think this is an improvement.  I'm a bit worried about catching the AvroRuntimeException
but, then ignoring it.  Could the AvroRuntimeException actually be something other than the
schema mismatch from an undeclared error?  If so, that error would get swallowed. 

> Incorrect handling of Undeclared Errors in IPC calls to SpecificResponder
> -------------------------------------------------------------------------
>
>                 Key: AVRO-723
>                 URL: https://issues.apache.org/jira/browse/AVRO-723
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.5.0
>            Reporter: Stephen Gargan
>            Priority: Minor
>         Attachments: undeclared-error.patch
>
>
> Undeclared errors thrown during service invocations are not getting returned correctly.
When they are encountered, the writeError method in the responder will try to encode them
using errors union for the message. However, because they are undeclared they are not present
in the union and encoding causes a further AvroRuntimeException. Its this "Not in union" exception
that gets returned to the client, not the undeclared problem which gets lost.
> The attached patch handles them like other system errors, calling to string on the exception
and writing this as the error to be returned.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message