avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AVRO-697) Install SIGPIPE handler in the Avro tools main method.
Date Tue, 23 Nov 2010 19:33:13 GMT

    [ https://issues.apache.org/jira/browse/AVRO-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934997#action_12934997
] 

Doug Cutting commented on AVRO-697:
-----------------------------------

So the problem is that signal handlers require implementation-specific code, is that right?
If so, then the reflection code should be carefully written to address that, so that things
still work if the classes change or are not present.  This seems like a useful feature, and
if this is the only way to implement it then I guess that's what we have to do.

> Install SIGPIPE handler in the Avro tools main method.
> ------------------------------------------------------
>
>                 Key: AVRO-697
>                 URL: https://issues.apache.org/jira/browse/AVRO-697
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>            Reporter: Patrick Linehan
>
> The following command should complete quickly, no matter how many records "myfile.avro"
contains:
>   java -jar avro-tools.jar tojson myfile.avro | head
> However, because the tool JAR's main method does not install a SIGPIPE handler, this
command can be quite slow for large files.
> Suggested fix is to install a handler which calls "System.exit(128 + signal.getNumber())"
in response to SIGPIPE.  Typically the signal number ("getNumber") is 13, but no need to hard
code it.
> Potential issues:
> * Tests which invoke Main.main() will necessarily force the signal handler to be installed.
 This may be undesirable, as the entire test JVM will be "infected" with the handler.  Workarounds
exist.  Does not bother me, personally, however.
> * Installing signal handlers generates compile-time warnings, if I'm not mistaken.  Workarounds
exist.  Does not bother me, personally, however.
> If this suggestion sounds reasonable, I'll post a patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message