avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AVRO-683) Specify types in static factory methods in Requestors
Date Mon, 25 Oct 2010 17:50:19 GMT

    [ https://issues.apache.org/jira/browse/AVRO-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924647#action_12924647
] 

Doug Cutting commented on AVRO-683:
-----------------------------------

Overall this looks like a good improvement.

A few small improvements I'd like to see before we commit this.
 - There are some whitespace-only changes to ReflectRequestor.  Can you please remove these?
 - We should try to use @SuppressWarnings("unchecked") as narrowly as possible.  Please move
this declaration to just those methods that require it.

Thanks!

> Specify types in static factory methods in Requestors
> -----------------------------------------------------
>
>                 Key: AVRO-683
>                 URL: https://issues.apache.org/jira/browse/AVRO-683
>             Project: Avro
>          Issue Type: Improvement
>    Affects Versions: 1.5.0
>            Reporter: Stephen Gargan
>            Priority: Trivial
>             Fix For: 1.5.0
>
>         Attachments: typed-requestors.patch
>
>
> The attached patch adds type information to the static factory methods in the SpecificRequestor
and ReflectRequestor to avoid the necessity of casting the proxy. 
> TestNamespace proxy = (TestNamespace)SpecificRequestor.getClient(TestNamespace.class,
client);
> becomes
> TestNamespace proxy = SpecificRequestor.getClient(TestNamespace.class, client);

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message