avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AVRO-641) add SASL to socket transport
Date Fri, 17 Sep 2010 21:22:34 GMT

    [ https://issues.apache.org/jira/browse/AVRO-641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910792#action_12910792
] 

Doug Cutting commented on AVRO-641:
-----------------------------------

> The only thing you lose is 8 characters in the .java file.

Because I enjoy beating dead horses, I note that the .class file also gains a few bytes. 
The java compiler, for whatever reason, doesn't know that the default value for booleans is
false, that the default value for ints is 0, etc., and generates code in the default constructor
for these.  In particular, initializing a boolean to false adds the following three instructions
to the constructor bytecode:

{code}
aload_0
iconst_0
putfield
{code}

But, to your point, that won't make any significant difference.

Thanks again for your reviews, and for all the code & text I copied from your Thrift implementation!

> add SASL to socket transport
> ----------------------------
>
>                 Key: AVRO-641
>                 URL: https://issues.apache.org/jira/browse/AVRO-641
>             Project: Avro
>          Issue Type: New Feature
>          Components: java
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>             Fix For: 1.4.1
>
>         Attachments: AVRO-641.patch, AVRO-641.patch, AVRO-641.patch, AVRO-641.patch,
AVRO-641.patch, AVRO-641.patch, AVRO-641.patch
>
>
> Java's socket transport is non-standard (not in the Avro spec) but might serve as a prototype
of a future standard transport (AVRO-341).
> It would be useful to extend it to support SASL-based authentication and encryption.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message