Return-Path: Delivered-To: apmail-avro-dev-archive@www.apache.org Received: (qmail 3949 invoked from network); 16 Aug 2010 23:10:35 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 16 Aug 2010 23:10:35 -0000 Received: (qmail 21830 invoked by uid 500); 16 Aug 2010 23:10:35 -0000 Delivered-To: apmail-avro-dev-archive@avro.apache.org Received: (qmail 21707 invoked by uid 500); 16 Aug 2010 23:10:34 -0000 Mailing-List: contact dev-help@avro.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@avro.apache.org Delivered-To: mailing list dev@avro.apache.org Received: (qmail 21699 invoked by uid 99); 16 Aug 2010 23:10:34 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Aug 2010 23:10:34 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,MIME_QP_LONG_LINE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [184.73.217.71] (HELO ip-10-202-7-187.ec2.internal) (184.73.217.71) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Aug 2010 23:10:27 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [127.0.0.1]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id 4E76D8A1EA; Mon, 16 Aug 2010 23:10:06 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: AVRO-613 From: "Patrick Wendell" To: "Philip Zeyliger" Date: Mon, 16 Aug 2010 23:10:06 -0000 Message-ID: <20100816231006.25772.80582@ip-10-202-7-187.ec2.internal> Cc: "Patrick Wendell" ,"Avro" In-Reply-To: <20100816184859.25773.58541@ip-10-202-7-187.ec2.internal> References: <20100816184859.25773.58541@ip-10-202-7-187.ec2.internal> X-Virus-Checked: Checked by ClamAV on apache.org ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/655/ ----------------------------------------------------------- (Updated 2010-08-16 16:10:06.234676) Review request for Avro and Philip Zeyliger. Changes ------- Did some re-factoring on this today so uploading the new diff. Summary ------- Basic collection of multiple traces and viewing servlet. Note: the javascri= pt files are external files, not mine. Diffs (updated) ----- lang/java/src/java/org/apache/avro/ipc/stats/StaticServlet.java 65a3cbe = lang/java/src/java/org/apache/avro/ipc/trace/SpanAggregator.java 65e4690 = lang/java/src/java/org/apache/avro/ipc/trace/StaticServlet.java PRE-CREAT= ION = lang/java/src/java/org/apache/avro/ipc/trace/Trace.java 46a2fce = lang/java/src/java/org/apache/avro/ipc/trace/TraceClientServlet.java 016d= 4d4 = lang/java/src/java/org/apache/avro/ipc/trace/TraceCollection.java PRE-CRE= ATION = lang/java/src/java/org/apache/avro/ipc/trace/TraceNode.java 5d62aa2 = lang/java/src/java/org/apache/avro/ipc/trace/TracePlugin.java c63ca5b = lang/java/src/java/org/apache/avro/ipc/trace/TracePluginConfiguration.jav= a bc1aaee = lang/java/src/java/org/apache/avro/ipc/trace/Util.java 01c9e9e = lang/java/src/java/org/apache/avro/ipc/trace/static/g.bar.js PRE-CREATION = lang/java/src/java/org/apache/avro/ipc/trace/static/jquery.tipsy.js PRE-C= REATION = lang/java/src/java/org/apache/avro/ipc/trace/static/protovis-r3.2.js PRE-= CREATION = lang/java/src/java/org/apache/avro/ipc/trace/static/tipsy.js PRE-CREATION = lang/java/src/java/org/apache/avro/ipc/trace/templates/collection.vm PRE-= CREATION = lang/java/src/java/org/apache/avro/ipc/trace/templates/common.vm PRE-CREA= TION = lang/java/src/java/org/apache/avro/ipc/trace/templates/overview.vm PRE-CR= EATION = lang/java/src/java/org/apache/avro/ipc/trace/templates/traceinput.vm PRE-= CREATION = lang/java/src/test/java/org/apache/avro/ipc/trace/TestBasicTracing.java 6= bc9153 = lang/java/src/test/java/org/apache/avro/ipc/trace/TestTraceCollection.jav= a PRE-CREATION = share/schemas/org/apache/avro/ipc/trace/avroTrace.avpr 6cf25d2 = Diff: http://review.cloudera.org/r/655/diff Testing ------- TestTraceCollection.java tests the new TraceCollection class. = Thanks, Patrick