avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Patrick Wendell" <pwend...@cloudera.com>
Subject Review Request: AVRO-614: Improve Trace frontend UI
Date Tue, 24 Aug 2010 18:08:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/716/
-----------------------------------------------------------

Review request for Avro and Philip Zeyliger.


Summary
-------

Improves frontend for avro trace by adding graphs.


Diffs
-----

  lang/java/src/java/org/apache/avro/ipc/trace/TraceCollection.java 0535d44 
  lang/java/src/java/org/apache/avro/ipc/trace/Util.java 2b6b0a8 
  lang/java/src/java/org/apache/avro/ipc/trace/templates/common.vm fb6a734 
  lang/java/src/java/org/apache/avro/ipc/trace/templates/node.vm 586a2e2 
  lang/java/src/java/org/apache/avro/ipc/trace/templates/overview.vm 2f10bbd 
  lang/java/src/java/org/apache/avro/ipc/trace/templates/traceinput.vm b8bff7c 
  lang/java/src/test/java/org/apache/avro/ipc/trace/TestBasicTracing.java dd95083 
  lang/java/src/test/java/org/apache/avro/ipc/trace/TestTracingUtil.java PRE-CREATION 

Diff: http://review.cloudera.org/r/716/diff


Testing
-------

Refactoring is covered by existing tests. New logic (list sampling) includes a unit-test.
Not quite sure how to test the client-side graphing stuff.


Thanks,

Patrick


Mime
View raw message