avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Hammerbacher (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (AVRO-544) Allow the HttpServer to serve forever without a call to Thread.sleep()
Date Tue, 06 Jul 2010 03:12:52 GMT

    [ https://issues.apache.org/jira/browse/AVRO-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885397#action_12885397
] 

Jeff Hammerbacher edited comment on AVRO-544 at 7/5/10 11:12 PM:
-----------------------------------------------------------------

For another point of reference, rather than calling {{start()}} in the ctor, {{org.apache.hadoop.http.HttpServer}}
exposes {{start()}}, {{stop()}}, and {{join()}} as public methods.

I think I like the Hadoop way best: pull {{start()}} out of the ctor and make it a public
method. That means existing client code needs to change to call {{start()}} after the ctor,
but I think it's worth it.

Thoughts?

      was (Author: hammer):
    For another point of reference, rather than calling {{start()}} in the ctor, {{org.apache.hadoop.http.HttpServer}}
exposes {{start()}, {{stop()}}, and {{join()}} as public methods.

I think I like the Hadoop way best: pull {{start()}} out of the ctor and make it a public
method. That means existing client code needs to change to call {{start()}} after the ctor,
but I think it's worth it.

Thoughts?
  
> Allow the HttpServer to serve forever without a call to Thread.sleep()
> ----------------------------------------------------------------------
>
>                 Key: AVRO-544
>                 URL: https://issues.apache.org/jira/browse/AVRO-544
>             Project: Avro
>          Issue Type: New Feature
>          Components: java
>            Reporter: Jeff Hammerbacher
>            Assignee: Jeff Hammerbacher
>             Fix For: 1.4.0
>
>         Attachments: AVRO-544-2.patch, AVRO-544.patch
>
>
> One way would be to expose the join() method on the HttpServer: http://jetty.codehaus.org/jetty/jetty-6/apidocs/org/mortbay/jetty/Server.html#join%28%29

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message