Mailing-List: contact dev-help@avro.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@avro.apache.org
Message-ID: <9429471.13291276628364143.JavaMail.jira@thor>
Date: Tue, 15 Jun 2010 14:59:24 -0400 (EDT)
From: "Doug Cutting (JIRA)" <jira@apache.org>
To: dev@avro.apache.org
Subject: [jira] Commented: (AVRO-573) Need to include Handshake Response
 when handling a system error on the Java server side
In-Reply-To: <15617334.39461276233376298.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/AVRO-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879070#action_12879070 ] 

Doug Cutting commented on AVRO-573:
-----------------------------------

> So in the client we'd skip the server protocol and hash reading

Those are both already optional in the HandshakeResponse, so this should require no change.

> look for a specific metadata key

Only if you want to generate a pretty error message.

> and then bail on trying to read the message as well (since we don't have a protocol)?

This is in logic that's already handling each value of HandshakeResponse.match.  Some cases already don't read the message (match=NONE).  So that logic could add a new case to handle match=ERROR.  Or, if that logic already throws an error when the match type is unrecognized then it would not need to be changed at all, unless you want a more descriptive error to be thrown.

> Sounds okay-ish.

Do you have an alternate proposal or suggested improvements?


> Need to include Handshake Response when handling a system error on the Java server side
> ---------------------------------------------------------------------------------------
>
>                 Key: AVRO-573
>                 URL: https://issues.apache.org/jira/browse/AVRO-573
>             Project: Avro
>          Issue Type: Bug
>          Components: java, spec
>            Reporter: Jeff Hammerbacher
>            Assignee: Doug Cutting
>             Fix For: 1.4.0
>
>
> System error is not handling everything right now. Details in the comments.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.