avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip Zeyliger (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AVRO-584) Update Histogram for Stats Plugin
Date Wed, 23 Jun 2010 23:28:50 GMT

    [ https://issues.apache.org/jira/browse/AVRO-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12881951#action_12881951
] 

Philip Zeyliger commented on AVRO-584:
--------------------------------------

I posted this to reviewboard and took a look there.  My comments are pasted in below.  I'm
curious to see how stats plugin is going to use the histogram data for recent stuff.  It seems
like it might be wiser to keep that data next to, but outside, of the histogram.  Consider
it.


Thanks!

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/225/#review272
-----------------------------------------------------------


A couple of nits on the documentation, but otherwise looks great.  When you create your next
patch, use --no-prefix in "git diff" to strip out the a/ and b/.  SVN folks prefer that.


lang/java/src/java/org/apache/avro/ipc/stats/Histogram.java
<http://review.hbase.org/r/225/#comment1134>

   If it's public, you may as well make your comment a javadoc.



lang/java/src/java/org/apache/avro/ipc/stats/Histogram.java
<http://review.hbase.org/r/225/#comment1135>

   I believe this is spelled "boundary" with plural "boundaries".



lang/java/src/java/org/apache/avro/ipc/stats/Histogram.java
<http://review.hbase.org/r/225/#comment1136>

   Mention that this keeps the last MAX_HISTORY_SIZE entries.  Are those recent entries in
order?  If so, you should mention whether you intend to keep that promise in the javadoc.


- Philip

> Update Histogram for Stats Plugin
> ---------------------------------
>
>                 Key: AVRO-584
>                 URL: https://issues.apache.org/jira/browse/AVRO-584
>             Project: Avro
>          Issue Type: Sub-task
>            Reporter: Patrick Wendell
>            Assignee: Patrick Wendell
>         Attachments: AVRO-584.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message