avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip Zeyliger (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AVRO-584) Update Histogram for Stats Plugin
Date Thu, 24 Jun 2010 05:52:51 GMT

    [ https://issues.apache.org/jira/browse/AVRO-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882057#action_12882057
] 

Philip Zeyliger commented on AVRO-584:
--------------------------------------

Quick question:

{quote}
+      Iterator<String> bucketsIt = this.getBuckets();
+      do {
+        outArray.add(bucketsIt.next());
+      } while (bucketsIt.hasNext());
+      outArray.add(bucketsIt.next());
{quote}

That looks a bit wrong, because you're calling bucketsIt.next() after bucketsIt.hasNext()
has returned false.  Am I missing something?

> Update Histogram for Stats Plugin
> ---------------------------------
>
>                 Key: AVRO-584
>                 URL: https://issues.apache.org/jira/browse/AVRO-584
>             Project: Avro
>          Issue Type: Sub-task
>            Reporter: Patrick Wendell
>            Assignee: Patrick Wendell
>         Attachments: AVRO-584.patch, AVRO-584.patch.v2.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message