avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AVRO-578) Add RPC Payload to RPCContext class
Date Wed, 23 Jun 2010 18:34:51 GMT

    [ https://issues.apache.org/jira/browse/AVRO-578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12881815#action_12881815
] 

Doug Cutting commented on AVRO-578:
-----------------------------------

Looks generally good.  Some nits:
 - I think we can use List in method signatures and field declarations. LinkedList should
be used as the implementation, since it supports faster prepends, but that detail can be hidden,
I think.
 - we could add a method like ByteBufferOutputStream#prepend(List<ByteBuffer>... lists).
 this could then have the option of converting things to perhaps a single ByteBuffer when
small, to reduce the number of i/o operations, since each ByteBuffer may correspond to a write
and/or read.  We may or may not make that optimization now, but it might be a nice option
to have later.
 - RPCContext: new public methods in a public class should have javadoc.  some of the existing
public methods there lack javadoc, which is a bug.
 - there's some commented-out code in Requestor that should probably be deleted.

> Add RPC Payload to RPCContext class
> -----------------------------------
>
>                 Key: AVRO-578
>                 URL: https://issues.apache.org/jira/browse/AVRO-578
>             Project: Avro
>          Issue Type: Sub-task
>          Components: java
>            Reporter: Patrick Wendell
>            Assignee: Patrick Wendell
>         Attachments: AVRO-578.patch, AVRO-578.patch.v2, AVRO-578.patch.v3, AVRO-578.patch.v4
>
>
> For stats/monitoring it is helpful to see how many bytes are encoded for a given RPC
call. Right now Encoder's don't track how many payload bytes are actually written out when
encoding is done.
> Ideally this bytesWritten() would be in Encoder interface, however not sure JSON plugin
can track the number of characters actually written, so alternatively just could be added
to BinaryEncoder, and stats plugin will only provide payload sizes when that encoder is used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message