avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Hammerbacher" <jeff.hammerbac...@gmail.com>
Subject Re: Review Request: Handle namespaces correctly in new Python implementation
Date Sat, 12 Jun 2010 03:39:46 GMT


> On 2010-06-11 20:38:54, Jeff Hammerbacher wrote:
> > trunk/lang/py/src/avro/schema.py, lines 253-255
> > <http://review.hbase.org/r/166/diff/1/?file=1234#file1234line253>
> >
> >     Actually, here is the issue: set_prop is used to add properties for printing.
You should add read-only parameters for member variables that don't get printed rather than
using set_prop.

Perhaps we should add a comment for others who modify this codebase to let them know the distinction?
You're the first person other than me to go through the implementation, so your feedback would
be appreciated.


- Jeff


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/166/#review206
-----------------------------------------------------------


On 2010-06-10 22:28:05, Jeff Hammerbacher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/166/
> -----------------------------------------------------------
> 
> (Updated 2010-06-10 22:28:05)
> 
> 
> Review request for Avro.
> 
> 
> Summary
> -------
> 
> Most recent patch that went into trunk. Let's figure out how to make it better at schema
printing and add some tests.
> 
> 
> This addresses bug AVRO-284.
>     http://issues.apache.org/jira/browse/AVRO-284
> 
> 
> Diffs
> -----
> 
>   trunk/lang/py/src/avro/protocol.py 953187 
>   trunk/lang/py/src/avro/schema.py 953187 
>   trunk/lang/py/test/test_protocol.py 953187 
>   trunk/lang/py/test/test_schema.py 953187 
> 
> Diff: http://review.hbase.org/r/166/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jeff
> 
>


Mime
View raw message