avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bruce Mitchener (JIRA)" <j...@apache.org>
Subject [jira] Updated: (AVRO-440) config.h output not correctly used
Date Fri, 05 Mar 2010 16:52:27 GMT

     [ https://issues.apache.org/jira/browse/AVRO-440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Bruce Mitchener updated AVRO-440:
---------------------------------

    Attachment: avro_config_h_check.diff

Apply AVRO-452's patch and then this one ... it will allow the use of stuff via config.h in
an autotools build without messing up a CMake build. That said, nothing actually uses config.h
at this point.


> config.h output not correctly used
> ----------------------------------
>
>                 Key: AVRO-440
>                 URL: https://issues.apache.org/jira/browse/AVRO-440
>             Project: Avro
>          Issue Type: Bug
>          Components: c
>    Affects Versions: 1.3.0
>            Reporter: Bruce Mitchener
>         Attachments: avro_config_h_check.diff
>
>
> While config.h is generated, it is only included from within st.c to make some things
work correctly within st.h.
> I would suggest changing things a little:
> * Put an include of config.h into src/avro_private.h
> * Include avro_private.h into all .c files.
> * Not sure if the values from config.h are needed in any of the tests or examples ...
I would hope not though and that this is fully insulated from being visible within anything
exposed by avro.h.
> Given some feedback, I can readily prepare a patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message