avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] Updated: (AVRO-321) Run Java RPC interop tests again
Date Tue, 02 Feb 2010 20:54:24 GMT

     [ https://issues.apache.org/jira/browse/AVRO-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Doug Cutting updated AVRO-321:
------------------------------

    Attachment: AVRO-321.patch

> Or, rather, a build.sh target? 

Oops.  I meant to add it to the 'test' target there.  Done.

> what's the difference between '@' and '$' in ant, in the segment below

@ refers to a task parameter, while $ refers to a property.  They're different namespaces
in Ant.

> RpcReceiveTool.java--sleep(1000)

Without that the server would sometimes exit before it had written the response back to the
client.  There's probably a better way of doing this.  Ideas?

> I think this might be more appropriately "uri protocol_file message_name (-data d|-file
f)" to indicate that one of data or file is required.

Done.

> read the file using the protocol schema:

Done.

> we should perhaps check that in.hasNext() is false.

I don't see the point.  This method is defined to read and return the first entry from a file,
not the only entry.

> There's no test for the "-file" path.

That's now tested by the top-level build.

> Might be nice to leave a comment why that sleep needs to be there.

Done.

> Run Java RPC interop tests again
> --------------------------------
>
>                 Key: AVRO-321
>                 URL: https://issues.apache.org/jira/browse/AVRO-321
>             Project: Avro
>          Issue Type: Test
>          Components: build, java
>            Reporter: Jeff Hammerbacher
>            Assignee: Doug Cutting
>             Fix For: 1.3.0
>
>         Attachments: AVRO-321.patch, AVRO-321.patch, AVRO-321.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message