avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AVRO-135) add compression to data files
Date Tue, 19 Jan 2010 00:46:54 GMT

    [ https://issues.apache.org/jira/browse/AVRO-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802006#action_12802006

Doug Cutting commented on AVRO-135:

> Pretend to be an OutputStream [ ... ]

I just looked at what your switch statements were doing in each case to devise the API.  The
API I provided above would make both the default and gzip codecs very small, while using an
OutputStream I think would take considerably more code than is in your current patch.

I wouldn't worry about making a codec API that's useful for other stuff.  Making it an abstract
class rather than an interface means we can revise it down the road without breaking folks.

> What do you mean by compress(byte[], int, int, Encoder) above?

That #compress() method would compress the bytes passed in and write them as a compressed
block to the Encoder.  The default no-op codec's impl would just write the bytes to the Encoder.

The #expand() method above would provide a decoder for a single compression block, reading
it from the provided Decoder.  The default no-op codec would just return the Decoder passed

> add compression to data files
> -----------------------------
>                 Key: AVRO-135
>                 URL: https://issues.apache.org/jira/browse/AVRO-135
>             Project: Avro
>          Issue Type: New Feature
>          Components: java, spec
>            Reporter: Doug Cutting
>            Assignee: Philip Zeyliger
>            Priority: Blocker
>             Fix For: 1.3.0
>         Attachments: AVRO-135.patch.txt
> We should add support for at least one compression codec to data files.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message