avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AVRO-275) Histogram class to keep RPC timing stats
Date Thu, 07 Jan 2010 20:23:54 GMT

    [ https://issues.apache.org/jira/browse/AVRO-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797780#action_12797780
] 

Doug Cutting commented on AVRO-275:
-----------------------------------

This looks fine, but, again, I don't think this makes much sense in Avro indepdendent of AVRO-270:
I'd prefer to commit this, AVRO-273 and AVRO-275 all in a single commit.  I also question
whether this needs to be public.  It's nice to have the timer and the histogram class pluggable,
but until someone wants to plug in different implementations, these just increase the number
of public APIs we have to maintain back-compatibly.  So my vote might be to make these package-private
for now.

> Histogram class to keep RPC timing stats
> ----------------------------------------
>
>                 Key: AVRO-275
>                 URL: https://issues.apache.org/jira/browse/AVRO-275
>             Project: Avro
>          Issue Type: New Feature
>          Components: java
>            Reporter: Philip Zeyliger
>            Assignee: Philip Zeyliger
>            Priority: Minor
>         Attachments: AVRO-275.patch.txt
>
>
> Class to keep a histogram of RPC timinigs for AVRO-270.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message