Return-Path: Delivered-To: apmail-hadoop-avro-dev-archive@minotaur.apache.org Received: (qmail 96335 invoked from network); 15 Dec 2009 23:01:44 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 15 Dec 2009 23:01:44 -0000 Received: (qmail 70798 invoked by uid 500); 15 Dec 2009 23:01:44 -0000 Delivered-To: apmail-hadoop-avro-dev-archive@hadoop.apache.org Received: (qmail 70764 invoked by uid 500); 15 Dec 2009 23:01:44 -0000 Mailing-List: contact avro-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: avro-dev@hadoop.apache.org Delivered-To: mailing list avro-dev@hadoop.apache.org Received: (qmail 70754 invoked by uid 99); 15 Dec 2009 23:01:44 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Dec 2009 23:01:44 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Dec 2009 23:01:42 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id ED9D0234C498 for ; Tue, 15 Dec 2009 15:01:21 -0800 (PST) Message-ID: <87168150.1260918081970.JavaMail.jira@brutus> Date: Tue, 15 Dec 2009 23:01:21 +0000 (UTC) From: "Kevin Oliver (JIRA)" To: avro-dev@hadoop.apache.org Subject: [jira] Commented: (AVRO-257) Dead code removal In-Reply-To: <784046756.1260910278215.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/AVRO-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791013#action_12791013 ] Kevin Oliver commented on AVRO-257: ----------------------------------- Yep. Doug, you beat me to the punch by a couple of minutes. Same thing I now have locally. Looks good to me. > Dead code removal > ----------------- > > Key: AVRO-257 > URL: https://issues.apache.org/jira/browse/AVRO-257 > Project: Avro > Issue Type: Bug > Components: java > Reporter: Kevin Oliver > Assignee: Kevin Oliver > Priority: Trivial > Fix For: 1.3.0 > > Attachments: AVRO-257.patch, AVRO-257.patch > > > There is dead code in org.apache.avro.reflect.ReflectData.validate(). The code is checking if datum is not an instance of Object. But it always is, as it is declared as Object and it is not null. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.