avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip Zeyliger (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AVRO-247) Broken test: org.apache.avro.TestDataFile$InteropTest.testGeneratedReflect()
Date Tue, 08 Dec 2009 19:08:18 GMT

    [ https://issues.apache.org/jira/browse/AVRO-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787664#action_12787664
] 

Philip Zeyliger commented on AVRO-247:
--------------------------------------

+1.

In testR10, it would be reasonable to check 'assertEquals("...R10", r10schema.getProperty(CLASS_PROP))'.

bq. c.isAnnotationPresent(Stringable.class)

For fail-fast, it might be good to check that c has a single string constructor.  Obviously,
the class reading might be totally different, but seems like this would catch errors in the
common case.  Up to you.

bq. Interop.java

I'm ok with having generated code not work with the reflection interface.  You could, again,
use annotations to make that work.  (@Utf8able on the Utf8 class, so that Avro reflection
understands both String and Utf8 might work.)  But I'm ok with it just not working.

> Broken test: org.apache.avro.TestDataFile$InteropTest.testGeneratedReflect()
> ----------------------------------------------------------------------------
>
>                 Key: AVRO-247
>                 URL: https://issues.apache.org/jira/browse/AVRO-247
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>            Reporter: Philip Zeyliger
>            Assignee: Doug Cutting
>             Fix For: 1.3.0
>
>         Attachments: AVRO-247.patch
>
>
> The current trunk has a broken java-interop test.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message