avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip Zeyliger (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AVRO-250) reflect's Union annotation should be applicable to method parameters and return types
Date Thu, 10 Dec 2009 21:25:18 GMT

    [ https://issues.apache.org/jira/browse/AVRO-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788933#action_12788933
] 

Philip Zeyliger commented on AVRO-250:
--------------------------------------

+1.  Looks good.

One thing that you could add a test for is to make sure that the correct methods are getting
chosen by SpecificResponder.respond().  Specifically, reflect should fail clearly if there
are multiple methods named the same.  But I'm content with that being tested implicitly, too.

> reflect's Union annotation should be applicable to method parameters and return types
> -------------------------------------------------------------------------------------
>
>                 Key: AVRO-250
>                 URL: https://issues.apache.org/jira/browse/AVRO-250
>             Project: Avro
>          Issue Type: New Feature
>          Components: java
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>             Fix For: 1.3.0
>
>         Attachments: AVRO-250.patch
>
>
> Some interface method parameters may optionally be null, which Avro's reflection does
not normally allow.  Similarly, some methods may return null instead of an instance of their
declared return type.  Avro's Union annotation should permit one to annotate such parameters
and methods so that the correct schema is inferred.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message