avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip Zeyliger (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AVRO-158) Add test to Java bindings for opening a non-empty file object container and successfully adding new elements
Date Sat, 07 Nov 2009 00:11:32 GMT

    [ https://issues.apache.org/jira/browse/AVRO-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774502#action_12774502
] 

Philip Zeyliger commented on AVRO-158:
--------------------------------------

I'm +1 the current patch.

Some responses to the comments:

bq. Do you have alternate wording?

No, it's fine.  It just seemed unrelated, so I was wondering what was going on.

bq. Factory methods make it hard to subclass.

Do you expect DataFileWriter to be subclassed?  It's not final, so presumably the answer is
"yes".  I'm fine with the current implementation, but something about DataFileWriter(File,
DatumWriter) being so different than DataFileWriter(Schema, OutputStream, DatumWriter) strikes
me as odd.

> Add test to Java bindings for opening a non-empty file object container and successfully
adding new elements
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: AVRO-158
>                 URL: https://issues.apache.org/jira/browse/AVRO-158
>             Project: Avro
>          Issue Type: Test
>          Components: java
>            Reporter: Jeff Hammerbacher
>            Assignee: Doug Cutting
>             Fix For: 1.3.0
>
>         Attachments: AVRO-158.patch, AVRO-158.patch
>
>
> Avro file object container are mutable and we should test that fact.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message