avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] Updated: (AVRO-171) Protocol Introspection can produce invalid forward references
Date Fri, 13 Nov 2009 00:36:39 GMT

     [ https://issues.apache.org/jira/browse/AVRO-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Doug Cutting updated AVRO-171:
------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed this.

> Protocol Introspection can produce invalid forward references
> -------------------------------------------------------------
>
>                 Key: AVRO-171
>                 URL: https://issues.apache.org/jira/browse/AVRO-171
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.2.0
>         Environment: java
>            Reporter: Mr Fish
>            Assignee: Doug Cutting
>             Fix For: 1.3.0
>
>         Attachments: AVRO-171.patch
>
>
> Take a look at this code which is what happens in the SpecificResponder handshake.
>         // server side
>         final Protocol protocol = ReflectData.get().getProtocol(MyServiceIface.class);
>         final String string = protocol.toString();
>         // client side
>         Protocol.parse(string);
> If you have a compound object made of 
> class A {
>     B1 b1;
>     B2 b2;
> }
> class B1 {
>     X x;
> }
> class B2 {
>     X x;
> }
> class X {
>  int i;
> }
> Then the types will be built up by RefectData.createSchema()
> A, B1, X, B2
> This is then reversed by RefectData.getProtocol() so B1 has no forward reference
> B2, X, B1, A.
> But this breaks B2
> org.apache.avro.SchemaParseException: Undefined name: "X"
>   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message