avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Hammerbacher (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AVRO-161) Add test to Python bindings for opening a non-empty file object container and successfully adding new elements
Date Wed, 04 Nov 2009 22:19:32 GMT

    [ https://issues.apache.org/jira/browse/AVRO-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773666#action_12773666
] 

Jeff Hammerbacher commented on AVRO-161:
----------------------------------------

Hey,

Could a Python committer please take a look at this patch? To address Philip's comments:

bq. You should add pydoc to _init_, create_new, and create_for_append, since it's not clear
which one one is supposed to use.

Sure, can do that. More generally, do we need a "create_new", or should __init__ default to
new?

bq. You should move the "from avro.genericio import DatumReader" up to the top of the file.

Can't due to some fun circular importing.

bq. In create_for_append and create_enw, the existence of the kwargs variable seems unnecessary

Sure, I can do that. I thought kwargs was cleaner, but happy to have constructors with seven
arguments if folks like them.

> Add test to Python bindings for opening a non-empty file object container and successfully
adding new elements
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: AVRO-161
>                 URL: https://issues.apache.org/jira/browse/AVRO-161
>             Project: Avro
>          Issue Type: Test
>          Components: python
>            Reporter: Jeff Hammerbacher
>         Attachments: AVRO-161.patch
>
>
> Avro file object container are mutable and we should test that fact. testio.py currently
just tests open a file for writing, writing a few records, closing the file, then reading
the file back in.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message