avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Scott Banachowski (JIRA)" <j...@apache.org>
Subject [jira] Updated: (AVRO-157) Changes from code review
Date Wed, 28 Oct 2009 20:28:59 GMT

     [ https://issues.apache.org/jira/browse/AVRO-157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Scott Banachowski updated AVRO-157:

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Committed revision 830750.

I went ahead and committed these, since changes were already previously suggested, and there
were no further comments.
Thanks to Thiru for his suggestions, and if anybody else has input please feel free to make
suggestions or submit patches.

> Changes from code review
> ------------------------
>                 Key: AVRO-157
>                 URL: https://issues.apache.org/jira/browse/AVRO-157
>             Project: Avro
>          Issue Type: Improvement
>          Components: c++
>            Reporter: Scott Banachowski
>         Attachments: applypatch157.sh, AVRO-157.patch
> A couple weeks ago, Thiru did a walk-through of the code, and made some suggestions,
which included:
> some reorganization
> thread safety
> renaming some functions
> some minor nit picking
> This patch is the result of those comments.  Nothing major has changed, but lots of code
was touched due to renames, etc.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message