avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AVRO-149) "avrotool" runner to execute avro commands from command-line
Date Fri, 16 Oct 2009 18:59:31 GMT

    [ https://issues.apache.org/jira/browse/AVRO-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766659#action_12766659

Doug Cutting commented on AVRO-149:

> BTW, if you want to just follow the latest changes, my history is up at http://github.com/philz/avro/commits/tool

I actually prefer to read the full patch again each time.  Really!

Also, when you upload a new version to Jira, please don't add a version number to the file
name.  Jira will datestamp it, and that way we don't end up with a big list of files at the
top of the page to choose among.  (The top one is not always the most recent.)

You renamed the script, but you did not rename the various comments that still use the term
"avrotool".  These should all be changed to "avroj", no?

Most other projects commonly use the bin/ directory for executable scripts, and do not have
two copies in releases.  I'd prefer that.  Is there a reason you've avoided that?  I don't
see the advantage of having the jar's version in the script: the script runs the code in a
relative directory, giving preference to the classes directory over any avro-XX.jar file found.

The warnings generated by the script will be annoying to developers like me, who will use
these scripts a lot.  They should at least be prefixed "Warning", but I'd really prefer they
were removed.  As I said above, the contract of the script is to run the code in the tree
where the script lives, giving precedence to built code over shipped code.  If an end-user
hacks some of our code and rebuilds, the script should run their hacked code without complaint.
 Many users hack open source code.  This is normal, and does not warrant warnings.

Finally, how about naming it 'avroj' rather than 'avroj.sh'?  Ant, forrest, findbugs, etc.
all name their scripts without a '.sh'.

> "avrotool" runner to execute avro commands from command-line
> ------------------------------------------------------------
>                 Key: AVRO-149
>                 URL: https://issues.apache.org/jira/browse/AVRO-149
>             Project: Avro
>          Issue Type: New Feature
>            Reporter: Philip Zeyliger
>            Assignee: Philip Zeyliger
>         Attachments: AVRO-149.patch.txt, AVRO-149.patch.v2.txt
> There's already an ant task to generate java code based on a schema, but you can't do
it from the command-line, with any ease.  I will shortly upload a patch that does just that.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message