avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hong Tang (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AVRO-22) Kill anonymous records or fix GenericDatumReader
Date Wed, 27 May 2009 16:50:45 GMT

    [ https://issues.apache.org/jira/browse/AVRO-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713640#action_12713640
] 

Hong Tang commented on AVRO-22:
-------------------------------

I am fine with moving the discussion of supporting multiple records with the same name (renaming
or not) to AVRO-23. In fact, I have been thinking that I could label anonymous record definitions
with some random ids, essentially the same way how GCC generates symbols defined in anonymous
namespaces. Maybe that could be how anonymous definitions are handled in Avro in general?

The only lingering issue I have is wrt the changes Doug checked in, which breaks the symmetry
between parse() and toString(). 

> Kill anonymous records or fix GenericDatumReader
> ------------------------------------------------
>
>                 Key: AVRO-22
>                 URL: https://issues.apache.org/jira/browse/AVRO-22
>             Project: Avro
>          Issue Type: Bug
>          Components: spec
>            Reporter: Raymie Stata
>            Assignee: Doug Cutting
>             Fix For: 1.0
>
>
> Anonymous record names are a pain, can we get rid of them?
> If not, I think I noticed a bug in GenericDatumReader.resolveExpected:
> {noformat}
>      if (branch.getType() == Type.RECORD) {
>        String name = branch.getName();
>        if (name == null || name.equals(actual.getName()))
>          return branch;
>      } else
>        return branch;
> {noformat}
> This doesn't seem to require that _both_ are null to match: if the name of {{branch}}
is null and the name {{actual}} is not, then we get a match, which I think is a bug.
> But again, let's just get rid of null names.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message