Return-Path: Delivered-To: apmail-hadoop-avro-dev-archive@minotaur.apache.org Received: (qmail 11570 invoked from network); 15 Apr 2009 05:20:37 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 15 Apr 2009 05:20:37 -0000 Received: (qmail 91691 invoked by uid 500); 15 Apr 2009 05:20:37 -0000 Delivered-To: apmail-hadoop-avro-dev-archive@hadoop.apache.org Received: (qmail 91652 invoked by uid 500); 15 Apr 2009 05:20:37 -0000 Mailing-List: contact avro-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: avro-dev@hadoop.apache.org Delivered-To: mailing list avro-dev@hadoop.apache.org Received: (qmail 91642 invoked by uid 99); 15 Apr 2009 05:20:37 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Apr 2009 05:20:37 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Apr 2009 05:20:35 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id DAE95234C003 for ; Tue, 14 Apr 2009 22:20:14 -0700 (PDT) Message-ID: <1223551166.1239772814882.JavaMail.jira@brutus> Date: Tue, 14 Apr 2009 22:20:14 -0700 (PDT) From: "Sharad Agarwal (JIRA)" To: avro-dev@hadoop.apache.org Subject: [jira] Updated: (AVRO-13) Use dictionary instead of if-else in validate In-Reply-To: <142550056.1239694155053.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/AVRO-13?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharad Agarwal updated AVRO-13: ------------------------------- Resolution: Fixed Status: Resolved (was: Patch Available) I just committed this! > Use dictionary instead of if-else in validate > --------------------------------------------- > > Key: AVRO-13 > URL: https://issues.apache.org/jira/browse/AVRO-13 > Project: Avro > Issue Type: Improvement > Components: python > Affects Versions: 1.0 > Reporter: Sharad Agarwal > Assignee: Sharad Agarwal > Fix For: 1.0 > > Attachments: AVRO-13_v1.patch > > > Currently validate in generic.py and reflect.py uses if-else. It would be efficient to use dictionary with keys as schema types. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.