avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AVRO-12) Bug in comparison of recurisive schemas
Date Tue, 21 Apr 2009 18:46:47 GMT

    [ https://issues.apache.org/jira/browse/AVRO-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701232#action_12701232
] 

Doug Cutting commented on AVRO-12:
----------------------------------

I would not oppose a patch that keeps the seen table on the stack rather than in a ThreadLocal.
 On one hand, it's a little cleaner, but on the other, it takes more code, since we effectively
need to replicate List#equals, List#hashCode, Map#equals and Map#hashCode, which the ThreadLocal
approach avoids, albeit in an ugly way.

> Bug in comparison of recurisive schemas
> ---------------------------------------
>
>                 Key: AVRO-12
>                 URL: https://issues.apache.org/jira/browse/AVRO-12
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.0
>            Reporter: Hong Tang
>            Assignee: Doug Cutting
>             Fix For: 1.0
>
>         Attachments: AVRO-12.patch
>
>
> Comparison of recursive schema will lead to infinite recursion (eventually leading to
java.lang.StackOverflowError.)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message