avro-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dcrea...@apache.org
Subject svn commit: r1188154 - in /avro/trunk: CHANGES.txt lang/c/src/resolved-writer.c
Date Mon, 24 Oct 2011 14:30:36 GMT
Author: dcreager
Date: Mon Oct 24 14:30:35 2011
New Revision: 1188154

URL: http://svn.apache.org/viewvc?rev=1188154&view=rev
Log:
AVRO-930. C: Fixed memory leak in resolved writer class

Thanks to Vivek Nadkarni for finding this and submitting a patch.

Modified:
    avro/trunk/CHANGES.txt
    avro/trunk/lang/c/src/resolved-writer.c

Modified: avro/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/avro/trunk/CHANGES.txt?rev=1188154&r1=1188153&r2=1188154&view=diff
==============================================================================
--- avro/trunk/CHANGES.txt (original)
+++ avro/trunk/CHANGES.txt Mon Oct 24 14:30:35 2011
@@ -215,6 +215,9 @@ Avro 1.6.0 (unreleased)
 
     AVRO-936. Avro Java does not build with Maven 2. (thiru)
 
+    AVRO-930. C: Fixed memory lead in resolved writer class. (Vivek
+    Nadkarni via dcreager)
+
 Avro 1.5.4 (12 September 2011)
 
   IMPROVEMENTS

Modified: avro/trunk/lang/c/src/resolved-writer.c
URL: http://svn.apache.org/viewvc/avro/trunk/lang/c/src/resolved-writer.c?rev=1188154&r1=1188153&r2=1188154&view=diff
==============================================================================
--- avro/trunk/lang/c/src/resolved-writer.c (original)
+++ avro/trunk/lang/c/src/resolved-writer.c Mon Oct 24 14:30:35 2011
@@ -2767,6 +2767,7 @@ avro_resolved_writer_new_memoized(memoiz
 		      avro_schema_type_name(wschema),
 		      is_avro_link(wschema)? "]": "",
 		      avro_schema_type_name(rschema));
+		avro_value_iface_incref(&saved->parent);
 		return saved;
 	} else {
 		DEBUG("Resolving %s%s%s->%s",



Mime
View raw message