avalon-phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Short" <ssh...@postx.com>
Subject RE: [PATCH] Bug 6025 - The System property "app.home" contains a non-String object
Date Tue, 24 Sep 2002 16:15:35 GMT

You also can't apply it because this method from class DefaultPolicy
seems to have been moved to SarPolicyResolver in the latest Phoenix.  I
also found that SimpleLogKitManager also needs to be changed - I can do
both of these if you agree to the change.

This code, wherever it lives, results in a File Object being placed into
the system properties, this is a problem for me because it breaks
OpenAdaptor. OpenAdaptor creates a SuperProperties object using the
system properties as defaults and it expects these to be Strings, which
is quite reasonable given the contract that Properties are supposed to
fulfill.

It is illegal for Properties to contain non-String objects, not only
because of the contract, but also because it will cause the Properties
store/save methods to break.  Phoenix should be using the
setProperty(String) method instead of the put method of the underlying
Hashmap.

I doubt that there are any backward compatibility issues with this
variable, "app.home", outside of Phoenix itself. 

Regards
Steve

> -----Original Message-----
> From: Peter Donald [mailto:peter@apache.org] 
> Sent: Tuesday, September 24, 2002 5:27 AM
> To: Avalon-Phoenix Developers List
> Subject: Re: [PATCH] Bug 6025 - The System property 
> "app.home" contains a non-String object
> 
> 
> On Tue, 24 Sep 2002 08:42, Steve Short wrote:
> > Looks like this bug wasn't fixed after all, here's a patch for it.
> 
> Unfortunately that patch can not be applied as it breaks backwards 
> compatability. However I still can not figure out why a 
> system property 
> contains a File object when looking at the code. Can you 
> explain why you 
> think this fix is needed?
> 
> -- 
> Cheers,
> 
> Peter Donald
> --------------------------------------------------
>  The fact that nobody understands you doesn't 
>  mean you're an artist.
> --------------------------------------------------
> 
> 
> --
> To unsubscribe, e-mail:   
> <mailto:avalon-phoenix-dev-> unsubscribe@jakarta.apache.org>
> 
> For additional commands, 
> e-mail: <mailto:avalon-phoenix-dev-help@jakarta.apache.org>
> 
> 

--
To unsubscribe, e-mail:   <mailto:avalon-phoenix-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:avalon-phoenix-dev-help@jakarta.apache.org>


Mime
View raw message