avalon-phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Donald <pe...@apache.org>
Subject Re: [PATCH] Re: Why is JMX support in builds optional?
Date Fri, 06 Sep 2002 12:25:38 GMT
On Fri, 6 Sep 2002 09:35, David W. wrote:
> The attached patch requires MX4J in builds.  It also eliminates the need
> for the other patch I posted (which seemed to get less attention than this
> topic...).  Again, I hope this is the right format for patches -- please
> complain at me if it isn't.

applied - thanks!

Usually we prefer patches in "unified" format which you can generate via 
passing "-u" option to cvs like

cvs diff -u Main.java

Usually we also prefer that the diffs be take from the root directory. ie we 
would prefer


$ cvs diff -u src/java/org/...../MyFile.java

over

$ cd jakarta-avalon-phoenix/src/java/org/...../
$ cvs diff -u MyFile.java

More details on submitting patches are available at bottom of

http://jakarta.apache.org/site/source.html

> Unresolved issues:
> -- The kernal.xml still uses NoopSystemManager as a default SystemManager

Okay - will do that now.

> -- Maybe place a jndi.properties file for MX4J in the classpath

that would be good.

-- 
Cheers,

Peter Donald
*-----------------------------------------------------*
| Never argue with an idiot, they'll drag you down to |
| their level, and beat you with experience           |
*-----------------------------------------------------* 


--
To unsubscribe, e-mail:   <mailto:avalon-phoenix-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:avalon-phoenix-dev-help@jakarta.apache.org>


Mime
View raw message