avalon-phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Donald <pe...@apache.org>
Subject Re: Cornerstone's Connection
Date Wed, 10 Jul 2002 11:00:45 GMT
On Wed, 10 Jul 2002 16:26, Marcos Sanz/Denic wrote:
> The class org.apache.avalon.cornerstone.blocks.connection.Connection is a
> bottle neck for the deployment of a performant Server. The lines
>
> getLogger().debug( "Starting connection on " + m_socket );
> getLogger().debug( "Ending connection on " + m_socket );
>
> perform a socket.toString() which turns up in an OS-call getHostByAddr().
> Reverse DNS lookups are deadly for a server open to the whole Internet.
> Could somebody at least change those lines to kind of
>
> if (getLogger().isDebugEnabled())
>      getLogger().debug( "Starting connection on " + m_socket );

Patch applied - thanks! I also added in the printout of dotted notation 
addresses rather than allowing DNS lookups.


-- 
Cheers,

Peter Donald
*-----------------------------------------------------*
| Never argue with an idiot, they'll drag you down to |
| their level, and beat you with experience           |
*-----------------------------------------------------* 


--
To unsubscribe, e-mail:   <mailto:avalon-phoenix-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:avalon-phoenix-dev-help@jakarta.apache.org>


Mime
View raw message