avalon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niclas Hedhman" <nic...@hedhman.org>
Subject Re: [patch] recent magic updates
Date Sat, 04 Sep 2004 09:44:36 GMT
Why is that breaking LogKit??

The change was made as it is fairly common naming convention with
*Test.java, as it has been recommended from the Junit camp.

Please clarify. I am unable to build from this tractor, so I can't check
myself.

Cheers
Niclas

----- Original Message -----
From: "Stephen McConnell" <mcconnell@apache.org>
To: "Avalon Developers List" <dev@avalon.apache.org>
Sent: Friday, September 03, 2004 8:26 PM
Subject: [patch] recent magic updates


>
>
> The following patch corrects a change introduced a couple of days ago to
> Magic's Context class.  The old change introduced the parameterization
> of unit test class filters but in the process changed the included
> pattern from only *UnitTest.java to *Test.java.  That change is breaking
> builds in logkit, meta, and repository.
>
> The following patch reverts the pattern to the original form which will
> restore normal build behavior.
>
> Stephen.
>
>
>
> Index: src/main/org/apache/avalon/tools/model/Context.java
> ===================================================================
> --- src/main/org/apache/avalon/tools/model/Context.java (revision 37479)
> +++ src/main/org/apache/avalon/tools/model/Context.java (working copy)
> @@ -146,7 +146,7 @@
>      /**
>      * default value
>      */
> -    public static final String TEST_INCLUDES_VALUE =
> "**/*TestCase.java, **/*Test.java";
> +    public static final String TEST_INCLUDES_VALUE =
> "**/*TestCase.java";
>
>      /**
>      * the key for the exclude pattern for test cases
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
> For additional commands, e-mail: dev-help@avalon.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
For additional commands, e-mail: dev-help@avalon.apache.org


Mime
View raw message