avalon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Berin Loritsch <blorit...@apache.org>
Subject Re: [Patch] #11.4 -- oops #11.3 blue up one of the tests
Date Wed, 28 May 2003 13:33:50 GMT
Anton Tagunov wrote:
> Really sorry about this - again a new version.

> 2. ==================
> 
> DefaultContainerManager was left without a logger as LoggerManager
> was no longer put to m_containerManagerContext.
> 
> This version of the patch adds a LOGGER constant to
> ContainerManagerConstants and makes ContextManager pass its
> own logger to DefaultContainerManager.

Ok.

> 
> This even looks a code simplification to me:
> 
> 1) we no longer deal with LoggerManager in DefaultContainerManager,
>    only with Logger

Ok.

> 
> 2) in the following rare situation
>    (usage scenario not promoted by any examples but
>    theoretically possible)
> 
>        ContextManager ctxm = new ContextManager( fortressConfig.getContext(),
>            my-unique-and-desired-logger );
> 
>        ContainerManager ctnm = new DefaultContainerManager( cm );
> 
>    ContainerManager will use the same logger as was
>    passed to the ContextManager, which is probably desirable
>    as ContextManager is only a spare part used by ContainerManager
>    and they should act as a one thing.
>    Without this change ContainerManager in this situation will use
>    loggerManager.getDefaultLogger().

Ok.  Sounds good so far.

> 
> P.S. Aren't you tired from my refactoring the code?
>      XP says it's a good thing, and what do you say? ;-)

I am rapidly reaching the point of Fortress being "Good Enough" for
release.  Unless you find any *bugs*, I suggest we hold off on the
refactoring until after the release.

> 
>      
> P.P.S.
> 
> Hopefully this has been my last pass on ContextManager,
> (unless someone says: oh, it was so nice to pass all the
> stuff to Container via Context, not ServiceManager :-)

No one will say that ;P



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
For additional commands, e-mail: dev-help@avalon.apache.org


Mime
View raw message