avalon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 19452] - XSLT processorImpl causes warnings to fired
Date Wed, 30 Apr 2003 12:29:39 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19452>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19452

XSLT processorImpl causes warnings to fired





------- Additional Comments From leo.sutic@inspireinfrastructure.com  2003-04-30 12:29 -------
1. The warnings have been squelched in the ExcaliburComponentSelector - the 
ComponentSelector.release() method works the same way as the 
ComponentManager.release() method, in that releasing a null is valid, and a no-
op. Thus, you never have to test when releasing. The reason for this is that 
you should be able to write code like this:

MyComponent comp = null;
try {
    comp = manager.lookup( MyComponent.ROLE );

    ... do stuff ...

} finally {
    manager.release( comp );
}

The final release shouldn't have to care whether the lookup succeeded or not.

2. Worrying about cleaning up if all required components aren't present is 
unneccessarily defensive coding, IMO. I think this is a perfect example of when 
a component should just crash, as the container has failed to live up to the 
contract.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
For additional commands, e-mail: dev-help@avalon.apache.org


Mime
View raw message