avalon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leo Sutic" <leo.su...@inspireinfrastructure.com>
Subject RE: SAXConfigurationHandler bug, was Re: no log messages from phoenix?
Date Thu, 23 May 2002 18:53:36 GMT


> -----Original Message-----
> From: Gregory Steuck [mailto:greg-avalon-dev@nest.cx] 
> Sent: den 23 maj 2002 20:37
> To: Avalon Developers List
> Subject: Re: SAXConfigurationHandler bug, was Re: no log 
> messages from phoenix?
> 
> 
> ... and I thought that patch wouldn't break anything. My apologies.
> 
> >>>>> "Peter" == Peter Royal <proyal@apache.org> writes:
> 
>     Peter> Actually you can, if you do <factory> </factory>
>     Peter> and the whitespace-preservation is off, you (should) get an
>     Peter> empty string since "\n".trim().equals("")
> 
> This would be a hack based on knowing SAXConfigurationHandler 
> internals as they are at this very moment.
> 
>     Peter> IMHO the change should stay since it keeps prior
>     Peter> behavior. (ie undeclared contract with the user). of course
>     Peter> i'm biased since i spent a few hours tracking it down... :)
> 
> Maybe this contract should be explicitly documented then? And 
> a unit test to guarantee that this contract won't be broken later?

If this is prior behavior, I agree. Document it and let the patch be
as is.

My reaction was against it being (to me) unintuitive - I only expected
the default value to be used when there was *no* value provided (as
opposed to an empty value).

/LS


--
To unsubscribe, e-mail:   <mailto:avalon-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:avalon-dev-help@jakarta.apache.org>


Mime
View raw message