avalon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeremias Maerki <jeremias.mae...@outline.ch>
Subject Re: [PATCH] Excalibur: FormatterFactory creates AvalonFormatter
Date Wed, 19 Dec 2001 07:18:22 GMT

On Tue, 18 Dec 2001 14:29:27 -0700 Mircea Toma wrote:
> Hi,
> 
> > Attached is a diff that enhances FormatterFactory (in
> > org.apache.avalon.excalibur.logger.factory) to accept a new value
> > ("avalon") for "type" which results in an
> > org.apache.avalon.framework.logger.AvalonFormatter to be instantiated.
> > I've also changed StreamTargetFactory to use FormatterFactory like
> > JMSTargetFactory does.
> 
> cool, I wanted to do this for a long time.

:-)

> > Can we please put on the TODO list to make FormatterFactory an interface
> > and and provide the current code as default implementation?
> 
> Do you have a scenario that would require this?
> Remember that you need a manager then to handle multiple FormatterFactory
> implementations!

I've had to create my own Formatter because until a few days ago,
there were certain limitations when rendering times. It would just be
very convenient to be able to supply different formatters using a
different factory. I don't think, that this is all so important. I just
thought, these changes would make LogKitManager a bit more flexible.

> > The other factories should probably use FormatterFactory, too.
> 
> will do :)
> 
> thanks

By the way, AvalonFormatter should probably be adjusted so it doesn't
mask the new time rendering functionality of LogKit in CVS.

If I only had enough time right now, I'd fix it myself.

Cheers,
Jeremias Märki

mailto:jeremias.maerki@outline.ch

OUTLINE AG
Postfach 3954 - Rhynauerstr. 15 - CH-6002 Luzern
Fon +41 (41) 317 2020 - Fax +41 (41) 317 2029
Internet http://www.outline.ch


--
To unsubscribe, e-mail:   <mailto:avalon-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:avalon-dev-help@jakarta.apache.org>


Mime
View raw message