avalon-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From leosu...@apache.org
Subject cvs commit: avalon-excalibur/component/src/java/org/apache/avalon/excalibur/component ExcaliburComponentSelector.java
Date Thu, 24 Apr 2003 12:48:47 GMT
leosutic    2003/04/24 05:48:47

  Modified:    component/src/java/org/apache/avalon/excalibur/component
                        ExcaliburComponentSelector.java
  Log:
  Removed the warning message issues when releasing a null component.
  As the ComponentManager contract specifies that release( null ) should be
  allowed and a no-op, it makes no sense to have the ComponentSelector
  work in another way. In my case, using Cocoon, I traced the release to this
  code in SourceResolverImpl:
  
          if( protocolPos != -1)
          {
              final String protocol = systemID.substring( 0, protocolPos );
              SourceFactory factory = null;
              try
              {
                  factory = (SourceFactory)m_factorySelector.select( protocol );
                  source = factory.getSource( systemID, parameters );
              }
              catch( final ServiceException ce )
              {
                  // no selector available, use fallback
              }
              finally
              {
                  m_factorySelector.release( factory );
              }
          }
  
  Which seems sensible to support.
  
  Revision  Changes    Path
  1.23      +1 -2      avalon-excalibur/component/src/java/org/apache/avalon/excalibur/component/ExcaliburComponentSelector.java
  
  Index: ExcaliburComponentSelector.java
  ===================================================================
  RCS file: /home/cvs/avalon-excalibur/component/src/java/org/apache/avalon/excalibur/component/ExcaliburComponentSelector.java,v
  retrieving revision 1.22
  retrieving revision 1.23
  diff -u -r1.22 -r1.23
  --- ExcaliburComponentSelector.java	29 Mar 2003 18:53:24 -0000	1.22
  +++ ExcaliburComponentSelector.java	24 Apr 2003 12:48:47 -0000	1.23
  @@ -305,7 +305,6 @@
       {
           if( null == component )
           {
  -            getLogger().warn( "Attempted to release a null component." );
               return;
           }
   
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: cvs-unsubscribe@avalon.apache.org
For additional commands, e-mail: cvs-help@avalon.apache.org


Mime
View raw message