avalon-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pro...@apache.org
Subject cvs commit: jakarta-avalon-logkit/src/test/org/apache/log/util/test UtilTestCase.java
Date Tue, 04 Feb 2003 13:50:33 GMT
proyal      2003/02/04 05:50:33

  Modified:    src/java/org/apache/log/output/io/rotate
                        RotateStrategyByDate.java
               src/java/org/apache/log/output/lf5 LF5LogTarget.java
                        LogKitLogRecord.java
               src/java/org/apache/log/util StackIntrospector.java
               src/test/org/apache/log/test InheritanceTestCase.java
               src/test/org/apache/log/util/test UtilTestCase.java
  Log:
  Fix semantic warnings:
    * Newlines at end of file
    * Proper order of modifiers
  
  Revision  Changes    Path
  1.6       +2 -2      jakarta-avalon-logkit/src/java/org/apache/log/output/io/rotate/RotateStrategyByDate.java
  
  Index: RotateStrategyByDate.java
  ===================================================================
  RCS file: /home/cvs/jakarta-avalon-logkit/src/java/org/apache/log/output/io/rotate/RotateStrategyByDate.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- RotateStrategyByDate.java	3 Feb 2003 17:40:14 -0000	1.5
  +++ RotateStrategyByDate.java	4 Feb 2003 13:50:33 -0000	1.6
  @@ -97,4 +97,4 @@
           }
           return true;
       }
  -}
  \ No newline at end of file
  +}
  
  
  
  1.3       +5 -5      jakarta-avalon-logkit/src/java/org/apache/log/output/lf5/LF5LogTarget.java
  
  Index: LF5LogTarget.java
  ===================================================================
  RCS file: /home/cvs/jakarta-avalon-logkit/src/java/org/apache/log/output/lf5/LF5LogTarget.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- LF5LogTarget.java	3 Feb 2003 17:40:16 -0000	1.2
  +++ LF5LogTarget.java	4 Feb 2003 13:50:33 -0000	1.3
  @@ -71,10 +71,10 @@
   public class LF5LogTarget implements LogTarget
   {
       /** Common monitor */
  -    static private LogBrokerMonitor c_defaultLogMonitor;
  +    private static LogBrokerMonitor c_defaultLogMonitor;
   
       /** Default context map formatter */
  -    static private Formatter        c_defaultContextFormatter = new PatternFormatter("");
  +    private static Formatter        c_defaultContextFormatter = new PatternFormatter("");
   
       /** Monitor for this LogTarget */
       private LogBrokerMonitor        m_monitor;
  @@ -111,7 +111,7 @@
       /**
        * Get the default <code>LogBrokerMonitor</code> instance.
        */
  -    public synchronized static LogBrokerMonitor getDefaultMonitor()
  +    public static synchronized LogBrokerMonitor getDefaultMonitor()
       {
           if( null == c_defaultLogMonitor )
           {
  @@ -135,4 +135,4 @@
   
           m_monitor.addMessage( new LogKitLogRecord( event, m_contextFormatter ) );
       }
  -}
  \ No newline at end of file
  +}
  
  
  
  1.3       +3 -3      jakarta-avalon-logkit/src/java/org/apache/log/output/lf5/LogKitLogRecord.java
  
  Index: LogKitLogRecord.java
  ===================================================================
  RCS file: /home/cvs/jakarta-avalon-logkit/src/java/org/apache/log/output/lf5/LogKitLogRecord.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- LogKitLogRecord.java	3 Feb 2003 17:40:16 -0000	1.2
  +++ LogKitLogRecord.java	4 Feb 2003 13:50:33 -0000	1.3
  @@ -159,8 +159,8 @@
       /**
        * The <code>LogLevel</code>s corresponding to LogKit priorities.
        */
  -    public final static List LOGKIT_LOGLEVELS =
  +    public static final List LOGKIT_LOGLEVELS =
           Arrays.asList(new LogLevel[] {
               LogLevel.FATAL, LogLevel.ERROR, LogLevel.WARN, LogLevel.INFO, LogLevel.DEBUG
           });
  -}
  \ No newline at end of file
  +}
  
  
  
  1.9       +2 -2      jakarta-avalon-logkit/src/java/org/apache/log/util/StackIntrospector.java
  
  Index: StackIntrospector.java
  ===================================================================
  RCS file: /home/cvs/jakarta-avalon-logkit/src/java/org/apache/log/util/StackIntrospector.java,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- StackIntrospector.java	3 Feb 2003 19:07:28 -0000	1.8
  +++ StackIntrospector.java	4 Feb 2003 13:50:33 -0000	1.9
  @@ -105,7 +105,7 @@
        * @exception SecurityException if an existing SecurityManager disallows construction
        *            of another SecurityManager
        */
  -    private synchronized static CallStack getCallStack()
  +    private static synchronized CallStack getCallStack()
           throws SecurityException
       {
           if( null == c_callStack )
  
  
  
  1.7       +7 -7      jakarta-avalon-logkit/src/test/org/apache/log/test/InheritanceTestCase.java
  
  Index: InheritanceTestCase.java
  ===================================================================
  RCS file: /home/cvs/jakarta-avalon-logkit/src/test/org/apache/log/test/InheritanceTestCase.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- InheritanceTestCase.java	3 Feb 2003 19:36:54 -0000	1.6
  +++ InheritanceTestCase.java	4 Feb 2003 13:50:33 -0000	1.7
  @@ -71,15 +71,15 @@
   public final class InheritanceTestCase
       extends TestCase
   {
  -    private final static String PATTERN = "%{priority}-%{message}";
  -    private final static PatternFormatter FORMATTER = new PatternFormatter( PATTERN );
  +    private static final String PATTERN = "%{priority}-%{message}";
  +    private static final PatternFormatter FORMATTER = new PatternFormatter( PATTERN );
   
  -    private final static String PATTERN2 = "Simon saids %{priority}-%{message}";
  -    private final static PatternFormatter FORMATTER2 = new PatternFormatter( PATTERN2 );
  +    private static final String PATTERN2 = "Simon saids %{priority}-%{message}";
  +    private static final PatternFormatter FORMATTER2 = new PatternFormatter( PATTERN2 );
   
  -    private final static String MSG = "No soup for you!";
  -    private final static String RMSG = "DEBUG-" + MSG;
  -    private final static String R2MSG = "Simon saids DEBUG-" + MSG;
  +    private static final String MSG = "No soup for you!";
  +    private static final String RMSG = "DEBUG-" + MSG;
  +    private static final String R2MSG = "Simon saids DEBUG-" + MSG;
   
       public InheritanceTestCase( final String name )
       {
  
  
  
  1.7       +4 -4      jakarta-avalon-logkit/src/test/org/apache/log/util/test/UtilTestCase.java
  
  Index: UtilTestCase.java
  ===================================================================
  RCS file: /home/cvs/jakarta-avalon-logkit/src/test/org/apache/log/util/test/UtilTestCase.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- UtilTestCase.java	3 Feb 2003 19:36:54 -0000	1.6
  +++ UtilTestCase.java	4 Feb 2003 13:50:33 -0000	1.7
  @@ -72,11 +72,11 @@
   public final class UtilTestCase
       extends TestCase
   {
  -    private final static String EOL = System.getProperty( "line.separator", "\n" );
  -    private final static RawFormatter FORMATTER = new RawFormatter();
  +    private static final String EOL = System.getProperty( "line.separator", "\n" );
  +    private static final RawFormatter FORMATTER = new RawFormatter();
   
  -    private final static String MSG = "No soup for you!";
  -    private final static String RMSG = MSG;
  +    private static final String MSG = "No soup for you!";
  +    private static final String RMSG = MSG;
   
       public UtilTestCase( final String name )
       {
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-cvs-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-cvs-help@jakarta.apache.org


Mime
View raw message