From reviews-return-20603-archive-asf-public=cust-asf.ponee.io@aurora.apache.org Wed Feb 7 20:25:26 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id BE58118065B for ; Wed, 7 Feb 2018 20:25:26 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id AE557160C5B; Wed, 7 Feb 2018 19:25:26 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 005C1160C3A for ; Wed, 7 Feb 2018 20:25:25 +0100 (CET) Received: (qmail 62023 invoked by uid 500); 7 Feb 2018 19:25:25 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 62001 invoked by uid 99); 7 Feb 2018 19:25:24 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Feb 2018 19:25:24 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id DB3E2C1F33; Wed, 7 Feb 2018 19:25:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.19 X-Spam-Level: * X-Spam-Status: No, score=1.19 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id a-qPu938UZiB; Wed, 7 Feb 2018 19:25:22 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 122D15F17D; Wed, 7 Feb 2018 19:25:22 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 69A6EE0144; Wed, 7 Feb 2018 19:25:21 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 3F7E6C40471; Wed, 7 Feb 2018 19:25:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5793032451044836420==" MIME-Version: 1.0 Subject: Re: Review Request 65433: Update Javascript Thrift to 0.10 From: Renan DelValle To: Bill Farner , David McLaughlin Cc: Aurora , Renan DelValle , Stephan Erb Date: Wed, 07 Feb 2018 19:25:21 -0000 Message-ID: <20180207192521.29714.92920@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Renan DelValle X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65433/ X-Sender: Renan DelValle X-ReviewBoard-ShipIt: 1 References: <20180131101123.59817.92255@reviews-vm2.apache.org> In-Reply-To: <20180131101123.59817.92255@reviews-vm2.apache.org> Reply-To: Renan DelValle X-ReviewRequest-Repository: aurora --===============5793032451044836420== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65433/#review197018 ----------------------------------------------------------- Ship it! Applied the patch locally and brought up a task. Works fine. Good catch Stephan! - Renan DelValle On Jan. 31, 2018, 2:11 a.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65433/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2018, 2:11 a.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Repository: aurora > > > Description > ------- > > We missed this change when bumping the Thrift version used by Python and > Java. https://reviews.apache.org/r/64290/ > > List of changes: https://github.com/apache/thrift/commits/master/lib/js/src/thrift.js > > > Diffs > ----- > > 3rdparty/javascript/scheduler/assets/js/thrift.js 111518739a7d353433ad59b7e48c84c2dbb546db > > > Diff: https://reviews.apache.org/r/65433/diff/1/ > > > Testing > ------- > > Manually verified that the UI is still working > > > Thanks, > > Stephan Erb > > --===============5793032451044836420==--