From reviews-return-20593-archive-asf-public=cust-asf.ponee.io@aurora.apache.org Mon Feb 5 18:58:56 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id C49CF180647 for ; Mon, 5 Feb 2018 18:58:56 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B4DCD160C5A; Mon, 5 Feb 2018 17:58:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 06913160C4B for ; Mon, 5 Feb 2018 18:58:55 +0100 (CET) Received: (qmail 47261 invoked by uid 500); 5 Feb 2018 17:58:55 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 47239 invoked by uid 99); 5 Feb 2018 17:58:54 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Feb 2018 17:58:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 70A13C1CAB; Mon, 5 Feb 2018 17:58:31 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.391 X-Spam-Level: ** X-Spam-Status: No, score=2.391 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id SYniIPy1a9Uj; Mon, 5 Feb 2018 17:58:30 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 3B79A5F6C8; Mon, 5 Feb 2018 17:58:30 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CF261E00EA; Mon, 5 Feb 2018 17:58:29 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 51821C40017; Mon, 5 Feb 2018 17:58:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5623590604886575671==" MIME-Version: 1.0 Subject: Re: Review Request 65494: Add task page to Scheduler UI From: Santhosh Kumar Shanmugham To: Santhosh Kumar Shanmugham , Reza Motamedi , Kai Huang Cc: David McLaughlin , Aurora Date: Mon, 05 Feb 2018 17:58:28 -0000 Message-ID: <20180205175828.45644.52884@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Santhosh Kumar Shanmugham X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65494/ X-Sender: Santhosh Kumar Shanmugham X-ReviewBoard-ShipIt: 1 References: <20180203002712.12716.98048@reviews-vm2.apache.org> In-Reply-To: <20180203002712.12716.98048@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: ui/src/main/js/pages/Task.js X-ReviewBoard-Diff-For: ui/src/main/js/pages/__tests__/Task-test.js Reply-To: Santhosh Kumar Shanmugham X-ReviewRequest-Repository: aurora --===============5623590604886575671== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65494/#review196813 ----------------------------------------------------------- Ship it! LGTM. I looked briefly at the Observer code and it should be easy to expose the thermos state as JSON, which can be fit into the scheduler UI. Happy to help with the Observer changes. - Santhosh Kumar Shanmugham On Feb. 2, 2018, 4:27 p.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65494/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2018, 4:27 p.m.) > > > Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar Shanmugham. > > > Repository: aurora > > > Description > ------- > > Add task page to Scheduler UI. I haven't created any inbound links to this yet because there isn't any really useful information, but we have a need to permalink to tasks from outside the Scheduler so right now this scratches that itch. > > If anyone has ideas about where we can add permalinks or inbound clicks.. let me know! In the future we could maybe bring some of the Observer stuff into this page and make it really useful. > > > Diffs > ----- > > ui/src/main/js/components/Breadcrumb.js 76c62709cf3ebf76e74e08573bc8b245a45d5fe9 > ui/src/main/js/components/TaskStatus.js 2e5a2b46121d6cc7c80c6d7589803a10973b5c1b > ui/src/main/js/components/__tests__/Breadcrumb-test.js 47f7afb29b9192e214040097dbfee2ff7f7e29ed > ui/src/main/js/index.js 9f94d4bd6f649d74bdd9c3aa99783e01cae25d93 > ui/src/main/js/pages/Task.js PRE-CREATION > ui/src/main/js/pages/__tests__/Task-test.js PRE-CREATION > ui/src/main/sass/components/_instance-page.scss 1da87dcb0f66c258179295b23bda5c895bf5308f > > > Diff: https://reviews.apache.org/r/65494/diff/1/ > > > Testing > ------- > > ./gradlew ui:test > > See screenshot for Vagrant test. > > > File Attachments > ---------------- > > Screen Shot 2018-02-02 at 4.22.16 PM.png > https://reviews.apache.org/media/uploaded/files/2018/02/03/588521b3-6014-4e63-aa4c-8389d4ed44e3__Screen_Shot_2018-02-02_at_4.22.16_PM.png > > > Thanks, > > David McLaughlin > > --===============5623590604886575671==--