aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jordan Ly <>
Subject Review Request 65810: Revert "Fix cron id collision bug by avoiding state in Quartz jobs"
Date Tue, 27 Feb 2018 05:58:30 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for Aurora, David McLaughlin and Santhosh Kumar Shanmugham.

Repository: aurora


This reverts commit e2ea191473397691605602c6e40c6aad8a56d81a.

A bug was found where jobs that were killed via the KILL_EXISTING flag would set `path` as
`null` in `JobDataMap` that would block concurrent runs, but that value would never be set
to `key` after the the delayed run finished because it would run outside of the `Job` execution.

The issue in will occur again, but it is rare and has
been around for a few years.

This bug was not caught in the unit test `testKillExisting` because `executeWithReplay` is
mocked and runs synchronously within the `Job` execution, allowing the `key` to be persisted.


  src/main/java/org/apache/aurora/scheduler/cron/quartz/ b77e032a245396143f103da1c0e5c9d508fe8098

  src/test/java/org/apache/aurora/scheduler/cron/quartz/ 8ae9bb56708f484bd32580efd74a425973b47093



`./gradlew test`

Manually verified in Vagrant environment that the bug no longer occurs.


Jordan Ly

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message