From reviews-return-20482-archive-asf-public=cust-asf.ponee.io@aurora.apache.org Wed Jan 10 20:58:49 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 25B7218072F for ; Wed, 10 Jan 2018 20:58:49 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 15917160C2E; Wed, 10 Jan 2018 19:58:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5AD6A160C1E for ; Wed, 10 Jan 2018 20:58:48 +0100 (CET) Received: (qmail 91961 invoked by uid 500); 10 Jan 2018 19:58:47 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 91944 invoked by uid 99); 10 Jan 2018 19:58:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jan 2018 19:58:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id D452DC0ACA; Wed, 10 Jan 2018 19:58:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.54 X-Spam-Level: ** X-Spam-Status: No, score=2.54 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_LOW=-0.7, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id S1BZp-0RRdrg; Wed, 10 Jan 2018 19:58:46 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 261375F36B; Wed, 10 Jan 2018 19:58:45 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7C962E04C7; Wed, 10 Jan 2018 19:58:44 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 51B0EC400F8; Wed, 10 Jan 2018 19:58:44 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2400865594373779247==" MIME-Version: 1.0 Subject: Re: Review Request 64825: Update packaging to latest Thrift, Mesos, and virtualenv From: Stephan Erb To: Bill Farner , Santhosh Kumar Shanmugham Cc: Aurora Date: Wed, 10 Jan 2018 19:58:44 -0000 Message-ID: <20180110195844.54009.23082@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Stephan Erb X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/64825/ X-Sender: Stephan Erb References: <20171223144832.2851.45066@reviews-vm2.apache.org> In-Reply-To: <20171223144832.2851.45066@reviews-vm2.apache.org> Reply-To: Stephan Erb X-ReviewRequest-Repository: aurora-packaging --===============2400865594373779247== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64825/ ----------------------------------------------------------- (Updated Jan. 10, 2018, 8:58 p.m.) Review request for Aurora, Santhosh Kumar Shanmugham and Bill Farner. Repository: aurora-packaging Description (updated) ------- * Remove the hardwired Thrift build dependency from the RPM and DEB packages. With the update to Thrift 0.10 and pants 1.4.0.dev23, the pants build script will download an appropriate Thrift compiler automatically. * Add missing system dependencies missing by the latest pants version. * Use latest virtualenv script from the main Aurora repo Diffs ----- build-support/virtualenv 3ed5b8c26007dc8ac2db3fc3157ba323b33664f2 builder/deb/debian-jessie/Dockerfile 1983fb603c3216d2ace726ec133b5876343cc2df builder/deb/ubuntu-trusty/Dockerfile 99c5481d367e9f1049bc2ecd331929bc73204442 builder/deb/ubuntu-xenial/Dockerfile dfdce150e38d081c02b991d5a24bec768c070c63 builder/rpm/centos-7/Dockerfile c12a61ffb0b835970e88d724ca3f70e7269f7638 specs/debian/control df863062e53034a6f04f457cd4a204daaa2cf80b specs/rpm/aurora.spec e1eff9c1f6092273b95104f9f4dd106846639a8d test/deb/debian-jessie/provision.sh 331a26c9c60a808f941fd54ee136db817bab2789 test/deb/ubuntu-trusty/provision.sh b9cbd438715049a0afdc85da17f79e59b870c113 test/deb/ubuntu-xenial/provision.sh 2adb879ec967bb0f07b3b535b0707972b4ac8d1e test/rpm/centos-7/Vagrantfile 8342b091eeefae35a592c79cf30ab3db82c349ca test/rpm/centos-7/provision.sh f41ffd17aaa3eaa314d746980c4f8e56f0373f11 Diff: https://reviews.apache.org/r/64825/diff/1/ Testing ------- ./build-artifact.sh builder/rpm/centos-7/ snapshot.tar.gz 0.20.0-snapshot ./test/test-artifact.sh test/rpm/centos-7 /repo/artifacts/aurora-centos-7/dist/rpmbuild/RPMS/x86_64 Thanks, Stephan Erb --===============2400865594373779247==--