Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F3C07200D64 for ; Tue, 12 Dec 2017 03:37:18 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id F23AF160C22; Tue, 12 Dec 2017 02:37:18 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 44AF6160C13 for ; Tue, 12 Dec 2017 03:37:18 +0100 (CET) Received: (qmail 65905 invoked by uid 500); 12 Dec 2017 02:37:17 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 65886 invoked by uid 99); 12 Dec 2017 02:37:16 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Dec 2017 02:37:16 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 866B21805D6; Tue, 12 Dec 2017 02:37:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.451 X-Spam-Level: **** X-Spam-Status: No, score=4.451 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id BXlX0_68NjrH; Tue, 12 Dec 2017 02:37:13 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B365F62844; Tue, 12 Dec 2017 02:29:29 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5C509E0E16; Tue, 12 Dec 2017 02:29:29 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 56266C403A9; Tue, 12 Dec 2017 02:29:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6949095499248023681==" MIME-Version: 1.0 Subject: Review Request 64523: Attempt #2 to fix flaky Webhook test From: Jordan Ly To: Stephan Erb Cc: Aurora , Jordan Ly Date: Tue, 12 Dec 2017 02:29:25 -0000 Message-ID: <20171212022925.4478.26501@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jordan Ly X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/64523/ X-Sender: Jordan Ly Reply-To: Jordan Ly X-ReviewRequest-Repository: aurora archived-at: Tue, 12 Dec 2017 02:37:19 -0000 --===============6949095499248023681== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64523/ ----------------------------------------------------------- Review request for Aurora and Stephan Erb. Bugs: AURORA-1961 https://issues.apache.org/jira/browse/AURORA-1961 Repository: aurora Description ------- Attempt #2 to fix the flaky Webhook test. Along the same lines of Stephan's change (https://reviews.apache.org/r/64482/), but opting to never start the Jetty server and forcing a connect exception. Overall, this flakiness has seemed to increase in volume over the past month. I've been running into it with a noticable fraction of internal/test builds. Diffs ----- src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java 1b5d2d02535345edfe6cf04d18d00434393f800b Diff: https://reviews.apache.org/r/64523/diff/1/ Testing ------- This change seems pretty hard to test considering the differences in environment and the unknown cause of the actual errors. Maybe we run the reviewbot on this repo repeatedly? Obviously not the most scientifically sound solution. Thanks, Jordan Ly --===============6949095499248023681==--